Merged
Conversation
Contributor
Author
Collaborator
|
I'm only about 80% sure RN won't need this, but okay. |
Collaborator
|
Thanks for cleaning up. |
Collaborator
|
Damn it. I actually need this in #5782 in order to move a component around. Okay if I revert this? |
Contributor
Author
|
Yeah, as per conversation, let's do it, to support getting nodes at times other than unmounting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Get rid of getNativeNode(), which was a temporary hack added in #5160 to solve #5151. We don't need it anymore, since we don't use React Ids.